Get rid of unnecessary

The number of bonus miles in MuffAir depends on the class and distance. To complete the program, you can add distance checks to each branch of the check for the flight class. But this option looks cumbersome.

The logic of calculating percentage is quite complicated, but I want to describe it as simply and elegantly as possible. Therefore, before adding a new condition, let’s change the structure of the existing code, but in such a way that it works as before. That is, we will refactor it.

Let’s look at the calculateMiles code. Inside, we have two ways out of the function:

var calculateMiles = function (distance, isBusinessClass) {
  if (isBusinessClass) {
    return …;
  } else {
    return …;
  }
};

It turns out that if we have an economy class, the program in any case will not get inside the first branch of the condition and will go further. Therefore, the else branch here is optional, it can be omitted.

var calculateMiles = function (distance, isBusinessClass) {
  if (isBusinessClass) {
    return …;
  }
  return …;
};