Let’s clean up a little

Let’s refactor our code and then finish writing the program for Muffin.

Why refactor again?

The thing is that later, we will need to compare the obtained results and log recommendations for the boss. It turns out that we will have to use the results of calculateFlights several times. Therefore, it is logical and correct to write these results into variables to store them for use later on. If we suddenly want to get data for other cities, we just change the values ​​of the arguments in one single place, not across the entire code.

What is the best way to name variables that contain the number of flights to Lisbon and Valencia? The first thing that comes to mind is to give the variables specific names: flightsToValencia and flightsToLisbon, but these names are too specific. If Muffin wants to fly to, say, Canadian Winnipeg instead of Valencia, the variable will have to be renamed. And it will have to be done every time the destination of the flight changes.

Instead of the destination, you could use the flight class to name the variables: flightsEconom and flightsBusiness. This option is also not the best one, because when we fly to different cities the class changes, but also the distance changes.

Let’s name the variables as simply as possible: flightsVariant1 and flightsVariant2. Then inside they can have any distances and flight classes.